DM-37786: allow PipelineTasks to control default dataset-query-constraint behavior. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 80.56% // Head: 80.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 80.56% 80.61% +0.04%
==========================================
Files 57 57
Lines 6304 6319 +15
Branches 1174 1280 +106
==========================================
+ Hits 5079 5094 +15
- Misses 981 982 +1
+ Partials 244 243 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@TallJimbo would you mind adding python 3.11 to the build matrix whilst you are doing this PR? It should work fine, ctrl_mpexec builds okay. |
natelust
approved these changes
Feb 14, 2023
|
I had the same misgivings and sense that it was the least-bad option, and I'll add some code comments to that effect. |
I wouldn't call this a hack, but it's being added here now to work around long-standing limitations involving spatial overlaps in QG generation, and I still want to fix those limitations directly. That makes me fit a *tiny* bit better about having absolutely no idea how I'd start to write a test for this, as the circumstances under which it appears in the real world require a lot of data (multiple tracts) and a pretty complicated graph and task, and we have none of that in ci_* packages, let alone here. So I'll be relying on one-off at-scale tests for now.
Even though these are debug-level, all of the other debug-level logging in GraphBuilder is much sparser.
I've long wondered why users occasionally reported the previous "this should't be possible" error message, and finally figured it out: initInputs don't get included in the initial data ID query, so follow-ups on those can fail even if repo state hasn't changed under us.
TallJimbo
force-pushed
the
tickets/DM-37786
branch
from
f970cba
to
0107320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes