Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37995: Add registry dataset types to QuantumGraph #307

Merged
merged 1 commit into from Feb 28, 2023

Conversation

andy-slac
Copy link
Contributor

A new QuantumGraph attribute registryDatasetTypes holds a collection of dataset types used in a graph. These dataset types match their registry definitions, which may be different (in storage class) from definitions of the same dataset types used for some quantum inputs. This list is used by the Quantum-backed butler to support trusted datastore functionality.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@andy-slac andy-slac changed the title Add registry dataset types to QuantumGraph (DM-37995) DM-37995: Add registry dataset types to QuantumGraph Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 80.64% // Head: 80.64% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4c80bb9) compared to base (80dcb53).
Patch coverage: 82.53% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          57       57           
  Lines        6318     6377   +59     
  Branches     1280     1303   +23     
=======================================
+ Hits         5095     5143   +48     
- Misses        979      985    +6     
- Partials      244      249    +5     
Impacted Files Coverage Δ
python/lsst/pipe/base/graphBuilder.py 65.31% <54.16%> (-0.69%) ⬇️
...thon/lsst/pipe/base/graph/_versionDeserializers.py 64.98% <100.00%> (+0.55%) ⬆️
python/lsst/pipe/base/graph/graph.py 82.27% <100.00%> (+0.65%) ⬆️
tests/test_quantumGraph.py 96.79% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

python/lsst/pipe/base/graphBuilder.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/graphBuilder.py Show resolved Hide resolved
tests/test_quantumGraph.py Show resolved Hide resolved
A new QuantumGraph attribute `registryDatasetTypes` holds a collection of
dataset types used in a graph. These dataset types match their registry
definitions, which may be different (in storage class) from definitions of
the same dataset types used for some quantum inputs. This list is used by
the Quantum-backed butler to support trusted datastore functionality.
@andy-slac andy-slac merged commit ef3da71 into main Feb 28, 2023
@andy-slac andy-slac deleted the tickets/DM-37995 branch February 28, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants