Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38210: Use butler.get() instead of deprecated getDirect() #312

Merged
merged 2 commits into from Apr 3, 2023

Conversation

timj
Copy link
Member

@timj timj commented Mar 3, 2023

Depends on lsst/daf_butler#797

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.03 🎉

Comparison is base (4921e76) 80.65% compared to head (51eedef) 80.69%.

❗ Current head 51eedef differs from pull request most recent head dd39aa6. Consider uploading reports for the commit dd39aa6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   80.65%   80.69%   +0.03%     
==========================================
  Files          57       57              
  Lines        6380     6372       -8     
  Branches     1303     1301       -2     
==========================================
- Hits         5146     5142       -4     
+ Misses        985      983       -2     
+ Partials      249      247       -2     
Impacted Files Coverage Δ
python/lsst/pipe/base/butlerQuantumContext.py 80.76% <66.66%> (+1.13%) ⬆️
tests/test_pipelineTask.py 97.34% <100.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj merged commit 7d2a789 into main Apr 3, 2023
8 checks passed
@timj timj deleted the tickets/DM-38210 branch April 3, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants