DM-38234: Improve DuplicateOutputError log message #313
Conversation
leeskelvin
force-pushed
the
tickets/DM-38234
branch
from
2996ba9
to
071a31e
Compare
leeskelvin
force-pushed
the
tickets/DM-38234
branch
from
071a31e
to
b3d73c3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
- Coverage 80.68% 80.65% -0.03%
==========================================
Files 57 57
Lines 6377 6379 +2
Branches 1303 1303
==========================================
Hits 5145 5145
- Misses 984 985 +1
- Partials 248 249 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leeskelvin
force-pushed
the
tickets/DM-38234
branch
from
b3d73c3
to
c15fc69
Compare
python/lsst/pipe/base/pipeTools.py
Outdated
| "DatasetType `{}' in task `{}' already appears as an output in task `{}'.".format( | ||
| dsTypeDescr.name, | ||
| taskDef.label, | ||
| dsTypeTaskLabels[dsTypeDescr.name], |
There was a problem hiding this comment.
I think an f-string might be more readable here; it's a bit disorienting that the string is laid out horizontally while the substitution arguments are laid out vertically.
| ) | ||
| dsTypeTaskLabels[dsTypeDescr.name] = taskDef.label |
There was a problem hiding this comment.
The fact that the test is against allOutputs while the insertion is against dsTypeTaskLabels is a bit awkward, logically. Is it already guaranteed that a task can't have two connections with the same dataset name?
There was a problem hiding this comment.
A single task cannot output the same dataset type twice. The important insertion is dsTypeDescr.name into outputs, which then gets subsumed into allOutputs to facilitate future checks. The insertion you've highlighted here is merely a book-keeping exercise that keeps a record of the prior tasks which output a given dataset type.
leeskelvin
force-pushed
the
tickets/DM-38234
branch
from
c15fc69
to
f65404b
Compare
Checklist
doc/changes