Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36162: Minor documentation fixes #317

Merged
merged 3 commits into from Apr 14, 2023
Merged

DM-36162: Minor documentation fixes #317

merged 3 commits into from Apr 14, 2023

Conversation

kfindeisen
Copy link
Member

This PR fixes some minor errors in the documentation of QuantumGraph.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3523509) 80.56% compared to head (d3b240a) 80.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files          57       57           
  Lines        6389     6389           
  Branches     1304     1304           
=======================================
  Hits         5147     5147           
  Misses        994      994           
  Partials      248      248           
Impacted Files Coverage Δ
python/lsst/pipe/base/graph/graph.py 82.27% <ø> (-0.51%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

python/lsst/pipe/base/graph/graph.py Outdated Show resolved Hide resolved
doc/changes/DM-36162.doc.md Outdated Show resolved Hide resolved
doc/changes/DM-36162.doc.md Outdated Show resolved Hide resolved
The docs claimed that these properties return a `list`, but they
actually return a generator. Code that expects a list will not work.
@kfindeisen
Copy link
Member Author

@TallJimbo If you'd like, please take a look at da64ee7 to make sure I haven't garbled anything.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional doc fixes look good, thanks!

The docs have been brought in line with current DM standards, and an
intersphinx link has been added for networkx types.
@kfindeisen kfindeisen merged commit baa836c into main Apr 14, 2023
10 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-36162 branch April 14, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants