Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38091: Allow InMemoryDatasetHandle to take kwargs for dataId #318

Merged
merged 5 commits into from Apr 15, 2023

Conversation

timj
Copy link
Member

@timj timj commented Apr 12, 2023

Some test users like to specify tract=N for example and don't want to have to decide whether they are
using a full DataCoordinate or an emulated one.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (baa836c) 80.52% compared to head (f85094f) 80.62%.

❗ Current head f85094f differs from pull request most recent head e433505. Consider uploading reports for the commit e433505 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   80.52%   80.62%   +0.09%     
==========================================
  Files          57       57              
  Lines        6389     6414      +25     
  Branches     1304     1308       +4     
==========================================
+ Hits         5145     5171      +26     
  Misses        995      995              
+ Partials      249      248       -1     
Impacted Files Coverage Δ
python/lsst/pipe/base/_dataset_handle.py 98.70% <100.00%> (-1.30%) ⬇️
tests/test_dataset_handle.py 97.43% <100.00%> (+0.33%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj requested a review from erykoff April 13, 2023 17:53
Some test users like to specify tract=N for example
and don't want to have to decide whether they are
using a full DataCoordinate or an emulated one.
@timj timj merged commit 110985a into main Apr 15, 2023
8 checks passed
@timj timj deleted the tickets/DM-38091 branch April 15, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants