Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38814: Drop obscore manager from config when making execution butler #321

Merged
merged 1 commit into from Apr 22, 2023

Conversation

andy-slac
Copy link
Contributor

@andy-slac andy-slac commented Apr 21, 2023

The fix is one additional line executionButlerBuilder.py, the rest is
a new unit test to reproduce the problem with execution butler and obscore.

Also needs lsst/daf_butler#826

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

The fix is one additional line `executionButlerBuilder.py`, the rest is
a new unit test to reproduce the problem with execution butler and obscore.
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 90.62% and project coverage change: +1.20 🎉

Comparison is base (17525e2) 80.60% compared to head (9e8c167) 81.81%.

❗ Current head 9e8c167 differs from pull request most recent head cc85667. Consider uploading reports for the commit cc85667 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   80.60%   81.81%   +1.20%     
==========================================
  Files          57       58       +1     
  Lines        6450     6477      +27     
  Branches     1323     1327       +4     
==========================================
+ Hits         5199     5299     +100     
+ Misses       1002      911      -91     
- Partials      249      267      +18     
Impacted Files Coverage Δ
tests/test_executionButler.py 87.50% <87.50%> (ø)
python/lsst/pipe/base/executionButlerBuilder.py 69.71% <100.00%> (+54.11%) ⬆️
python/lsst/pipe/base/tests/simpleQGraph.py 71.97% <100.00%> (+0.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@andy-slac andy-slac merged commit f2bda7e into main Apr 22, 2023
8 checks passed
@andy-slac andy-slac deleted the tickets/DM-38814 branch April 22, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants