DM-38780: Update graph builder to always produce resolved refs #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 82.09% 82.27% +0.18%
==========================================
Files 59 60 +1
Lines 6600 6663 +63
Branches 1353 1360 +7
==========================================
+ Hits 5418 5482 +64
+ Misses 913 909 -4
- Partials 269 272 +3
☔ View full report in Codecov by Sentry. |
andy-slac
force-pushed
the
tickets/DM-38780
branch
from
ec167fc
to
809322e
Compare
This new method updates run collection name and dataset IDs for all output and intermediate datasets in a graph.
andy-slac
force-pushed
the
tickets/DM-38780
branch
from
809322e
to
3f065da
Compare
TallJimbo
approved these changes
Apr 28, 2023
andy-slac
commented
Apr 28, 2023
This commit also fixes a bug in graph builder which produced un-connected graphs in case of existing intermediate datasets.
Co-authored-by: Jim Bosch <jbosch@astro.princeton.edu>
andy-slac
force-pushed
the
tickets/DM-38780
branch
from
2fa9b4f
to
6212ec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also fixes a bug in graph builder which produced un-connected
graphs in case of existing intermediate datasets.
Add method
QuantumGraph.updateRun. This new method updates run collection name and dataset IDs for all outputand intermediate datasets in a graph.
Checklist
doc/changes