DM-38948: Fix handling of dataset query constraint options in QG generation. #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 82.33% 82.19% -0.15%
==========================================
Files 60 60
Lines 6663 6678 +15
Branches 1360 1366 +6
==========================================
+ Hits 5486 5489 +3
- Misses 907 916 +9
- Partials 270 273 +3
☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-38948
branch
from
29bdac9
to
d47d299
Compare
|
I have not added a changelog entry because I figure we'll get this in pretty soon, and hence aside from a daily or two it'll be as if nothing happened. Happy to entertain other perspectives on that. |
andy-slac
approved these changes
Apr 29, 2023
Comment on lines
1106
to
1107
| # container to accumulate datasets in self.missing, if the common | ||
| # dataIds were not constrained on dataset type existence. |
There was a problem hiding this comment.
"container to" is probably not needed here?
...Probably. It was definitely broken by DM-38780, but there are still no tests to show that it works now.
TallJimbo
force-pushed
the
tickets/DM-38948
branch
from
d47d299
to
144ec73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...Probably. It was definitely broken by DM-38780, but there are still no tests to show that it works now.
Checklist
doc/changes