DM-38957: Ignore new data IDs in QG gen follow-up queries. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These data IDs that were not present in the initial data ID query can come about because we have to drop the post-query region-filtering when doing the follow-up queries for datasets.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 82.16% 82.15% -0.01%
==========================================
Files 60 60
Lines 6678 6681 +3
Branches 1366 1368 +2
==========================================
+ Hits 5487 5489 +2
- Misses 917 918 +1
Partials 274 274
☔ View full report in Codecov by Sentry. |
andy-slac
approved these changes
May 1, 2023
| @@ -1097,7 +1097,8 @@ def resolveDatasetRefs( | |||
| except MissingDatasetTypeError: | |||
| resolvedRefQueryResults = [] | |||
| for resolvedRef in resolvedRefQueryResults: | |||
| assert resolvedRef.dataId in refs | |||
| if resolvedRef.dataId not in refs: | |||
There was a problem hiding this comment.
Maybe catching KeyError in this case would be more efficient, avoiding searching the map twice, but it probably does not matter.
There was a problem hiding this comment.
I've seen some examples of Python dict performance on these sorts of questions being completely counterintuitive, so while I do try to avoid double-lookups (usually with if (x := d.get(k)) is not None, these days), that's mostly for consistency rather than any actual expectation of performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These data IDs that were not present in the initial data ID query can come about because we have to drop the post-query region-filtering when doing the follow-up queries for datasets.
Checklist
doc/changes