Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38953 (again): dynamic connections support, fixed #333

Merged
merged 2 commits into from May 12, 2023

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented May 11, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This reverts commit c64c9a3.
This was broken by the original version of DM-38953, because I hadn't
been considering inheritance as a legitimate reason why a connection
might be defined twice in the same class.  Now that case is handled
better than before, because previously changing the type of the
connection would have silently left the class in an inconsistent state.
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 96.06% and project coverage change: +0.52 🎉

Comparison is base (3fc0ca6) 82.13% compared to head (37ecbd5) 82.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   82.13%   82.65%   +0.52%     
==========================================
  Files          60       62       +2     
  Lines        6723     6960     +237     
  Branches     1373     1381       +8     
==========================================
+ Hits         5522     5753     +231     
- Misses        923      926       +3     
- Partials      278      281       +3     
Impacted Files Coverage Δ
python/lsst/pipe/base/graphBuilder.py 63.97% <ø> (ø)
python/lsst/pipe/base/tests/pipelineStepTester.py 0.00% <0.00%> (ø)
tests/test_pipelineIR.py 98.34% <ø> (-0.17%) ⬇️
python/lsst/pipe/base/connections.py 77.58% <90.82%> (+4.69%) ⬆️
python/lsst/pipe/base/connectionTypes.py 87.09% <92.85%> (+2.24%) ⬆️
python/lsst/pipe/base/pipelineIR.py 85.35% <97.72%> (-0.93%) ⬇️
tests/test_dynamic_connections.py 98.90% <98.90%> (ø)
python/lsst/pipe/base/__init__.py 100.00% <100.00%> (ø)
...n/lsst/pipe/base/automatic_connection_constants.py 100.00% <100.00%> (ø)
python/lsst/pipe/base/config.py 67.46% <100.00%> (+0.80%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TallJimbo TallJimbo merged commit 943382d into main May 12, 2023
10 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-38953 branch May 12, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant