Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-4037: Require non-empty doc string for config parameters #336

Merged
merged 1 commit into from Jun 9, 2023

Conversation

enourbakhsh
Copy link
Contributor

@enourbakhsh enourbakhsh commented May 17, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (b6be565) 82.65% compared to head (aa64232) 82.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   82.65%   82.62%   -0.03%     
==========================================
  Files          66       66              
  Lines        7124     7124              
  Branches     1387     1387              
==========================================
- Hits         5888     5886       -2     
- Misses        992      993       +1     
- Partials      244      245       +1     
Impacted Files Coverage Δ
tests/test_configOverrides.py 100.00% <100.00%> (ø)
tests/test_testUtils.py 99.04% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@enourbakhsh enourbakhsh force-pushed the tickets/DM-4037 branch 2 times, most recently from e9b01e0 to 91bc58b Compare May 18, 2023 20:07
@enourbakhsh enourbakhsh force-pushed the tickets/DM-4037 branch 2 times, most recently from 179fe59 to bc748af Compare June 8, 2023 04:21
@enourbakhsh enourbakhsh changed the title DM-4037: Fix empty docstrings DM-4037: Require non-empty doc string for config parameters Jun 8, 2023
@enourbakhsh enourbakhsh merged commit 2d6725e into main Jun 9, 2023
9 of 10 checks passed
@enourbakhsh enourbakhsh deleted the tickets/DM-4037 branch June 9, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants