Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37704: Update code to use resolved refs. #338

Merged
merged 3 commits into from May 26, 2023
Merged

Conversation

andy-slac
Copy link
Contributor

All references are now resolved, retiring the code that checked for unresolved refs.

ButlerQuantumContext interface is updated. The constructor now takes a
LimitedButler instance only and factory methods from_full and from_limited are gone.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

All references are now resolved, retiring the code that checked for unresolved refs.
Now we have resolved refs everywhere which means we do not need to unresolve
them for full butler and we can use LimitedButler.put for everything. The
constructor now takes a LimitedButler instance only and factory methods
`from_full` and `from_limited` are gone.
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: +0.01 🎉

Comparison is base (807f6e7) 82.56% compared to head (2682e8b) 82.58%.

❗ Current head 2682e8b differs from pull request most recent head dfcc5a2. Consider uploading reports for the commit dfcc5a2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   82.56%   82.58%   +0.01%     
==========================================
  Files          62       62              
  Lines        6970     6925      -45     
  Branches     1385     1368      -17     
==========================================
- Hits         5755     5719      -36     
+ Misses        934      929       -5     
+ Partials      281      277       -4     
Impacted Files Coverage Δ
...ython/lsst/pipe/base/script/transfer_from_graph.py 12.50% <ø> (ø)
tests/test_graphBuilder.py 95.58% <ø> (+1.40%) ⬆️
python/lsst/pipe/base/executionButlerBuilder.py 66.21% <60.00%> (+0.44%) ⬆️
python/lsst/pipe/base/butlerQuantumContext.py 79.38% <100.00%> (-1.76%) ⬇️
python/lsst/pipe/base/graphBuilder.py 64.25% <100.00%> (+0.11%) ⬆️
python/lsst/pipe/base/testUtils.py 93.47% <100.00%> (+2.81%) ⬆️
tests/test_pipelineTask.py 97.23% <100.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

doc/changes/DM-37704.api.md Outdated Show resolved Hide resolved
@andy-slac andy-slac force-pushed the tickets/DM-37704 branch 2 times, most recently from 506977d to dfcc5a2 Compare May 26, 2023 01:31
@andy-slac andy-slac merged commit ccb5b7f into main May 26, 2023
8 checks passed
@andy-slac andy-slac deleted the tickets/DM-37704 branch May 26, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants