DM-38952: revive pipeline mock system and move it here (from ctrl_mpexec) #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 82.54% 82.62% +0.07%
==========================================
Files 61 66 +5
Lines 6865 7124 +259
Branches 1363 1387 +24
==========================================
+ Hits 5667 5886 +219
- Misses 925 993 +68
+ Partials 273 245 -28
☔ View full report in Codecov by Sentry. |
2 tasks
timj
approved these changes
May 31, 2023
| # docstring is inherited from base class | ||
| return value | ||
|
|
||
| def visitRangeLiteral(self, start: int, stop: int, stride: Optional[int], node: Node) -> Any: |
There was a problem hiding this comment.
Suggested change
| def visitRangeLiteral(self, start: int, stop: int, stride: Optional[int], node: Node) -> Any: | |
| def visitRangeLiteral(self, start: int, stop: int, stride: int | None, node: Node) -> Any: |
Just in case you want to take a quick modernization pass on this file -- there aren't many old-style annotations (changing to visit_range_literal might be a step too far).
There was a problem hiding this comment.
Good point; I've updated the annotations. Changing the method names would require changing them in a bunch of places in daf_butler, too (though I guess they're at least internal APIs), so I agree that's a step too far.
| if not isinstance(refs, list): | ||
| refs = [refs] | ||
| inputs_list = [] | ||
| for ref in refs: |
There was a problem hiding this comment.
Suggested change
| for ref in refs: | |
| for ref in lsst.utils.iteration.ensure_iterable(refs): |
Then you don't need the 2 lines converting to a list above. Similarly in the outputRefs loop below.
TallJimbo
force-pushed
the
tickets/DM-38952
branch
from
2ee4e68
to
b1e11a1
Compare
This has bitrotted and does not work anymore, but before fixing that I wanted to get a clean transfer of what we had before with only import/formatting changes. I haven't moved the mock for ButlerQuantumContext that these classes assume, because I'll be modifying them to use the MockStorageClass and MockDataset classes instead.
This seems to have been introduced by switching derivedComponents to Mapping instead of dict, but that shouldn't have mattered.
TallJimbo
force-pushed
the
tickets/DM-38952
branch
from
b1e11a1
to
fee8c7b
Compare
This allows the instrument embedded in a pipeline to be passed into the graph generation algorithm even when the pipeline is converted to a sequence of TaskDef objects in advance.
TallJimbo
force-pushed
the
tickets/DM-38952
branch
from
42393fb
to
7dcc699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes