New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-39605: Use butler.dimensions rather than deprecated butler.registry.dimensions #343
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 82.59% 82.64% +0.04%
==========================================
Files 66 66
Lines 7124 7133 +9
Branches 1387 1387
==========================================
+ Hits 5884 5895 +11
+ Misses 994 993 -1
+ Partials 246 245 -1
☔ View full report in Codecov by Sentry. |
There are still very many warnings from ruff but this configuration matches our docstyle and naming ignores.
@andy-slac (or even @TallJimbo) I'm not sure how you want to tackle this huge change or whether it's even worth while looking at it at all. In summary the changes are:
|
I also added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a small bunch of minor comments.
@@ -197,10 +196,10 @@ def get( | |||
|
|||
def put( | |||
self, | |||
values: Union[Struct, List[Any], Any], | |||
dataset: Union[OutputQuantizedConnection, List[DatasetRef], DatasetRef], | |||
values: Struct | list[Any] | Any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not Any
make both Struct
and list
not useful at all? We should probably start using object
instead of Any
in places where we want some type checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think it's using the annotation as a sort of documentation. Not sure whether to leave it as is or use Any
and rely on the docstring.
Checklist
doc/changes