Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39876: Force v1 pydantic API if running v2 #350

Merged
merged 3 commits into from Jul 5, 2023
Merged

Conversation

timj
Copy link
Member

@timj timj commented Jul 4, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj requested a review from andy-slac July 4, 2023 05:09
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.09 ⚠️

Comparison is base (07d78ed) 82.78% compared to head (4953f65) 82.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   82.78%   82.69%   -0.09%     
==========================================
  Files          66       66              
  Lines        7237     7246       +9     
  Branches     1408     1291     -117     
==========================================
+ Hits         5991     5992       +1     
- Misses        999     1006       +7     
- Partials      247      248       +1     
Impacted Files Coverage Δ
python/lsst/pipe/base/_task_metadata.py 96.63% <50.00%> (-0.93%) ⬇️
python/lsst/pipe/base/graph/quantumNode.py 86.15% <50.00%> (-2.56%) ⬇️
...ython/lsst/pipe/base/tests/mocks/_storage_class.py 51.38% <50.00%> (-0.39%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj merged commit e6f13a4 into main Jul 5, 2023
9 of 11 checks passed
@timj timj deleted the tickets/DM-39876 branch July 5, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants