DM-39857: Stop using pytest-flake8 and add ruff config #353

timj · 2023-07-05T20:37:49Z

Checklist

ran Jenkins
added a release note for user-visible changes to doc/changes

codecov · 2023-07-05T20:43:49Z

Codecov Report

Patch coverage: 92.85% and project coverage change: -0.01 ⚠️

Comparison is base (e167ea5) 82.74% compared to head (590180b) 82.74%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   82.74%   82.74%   -0.01%     
==========================================
  Files          66       66              
  Lines        7281     7269      -12     
  Branches     1418     1418              
==========================================
- Hits         6025     6015      -10     
+ Misses       1007     1006       -1     
+ Partials      249      248       -1

Impacted Files	Coverage Δ
python/lsst/pipe/base/_task_metadata.py	`96.63% <ø> (ø)`
python/lsst/pipe/base/config.py	`70.12% <ø> (ø)`
python/lsst/pipe/base/connections.py	`78.14% <ø> (ø)`
python/lsst/pipe/base/graph/quantumNode.py	`86.15% <ø> (ø)`
python/lsst/pipe/base/pipelineTask.py	`100.00% <ø> (ø)`
...ython/lsst/pipe/base/tests/mocks/_pipeline_task.py	`34.54% <ø> (ø)`
...ython/lsst/pipe/base/tests/mocks/_storage_class.py	`51.38% <ø> (ø)`
python/lsst/pipe/base/tests/simpleQGraph.py	`71.42% <ø> (ø)`
tests/test_cliCmdRegisterInstrument.py	`100.00% <ø> (ø)`
tests/test_connections.py	`99.03% <ø> (-0.01%)`	⬇️
... and 20 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

andy-slac

Looks good, few minor comments.

.pre-commit-config.yaml

doc/conf.py

python/lsst/pipe/base/_quantumContext.py

python/lsst/pipe/base/graph/quantumNode.py

python/lsst/pipe/base/pipelineIR.py

tests/test_cliCmdRegisterInstrument.py

tests/test_pipelineTask.py

ruff seems to be getting confused and is insisting that __len__ and __iter__ are class methods and so should not use "self".

Neither ruff nor pydocstyle understand that "parameters:" in a code-block in a docstring is not in fact a numpydoc Parameters directive that has gone wrong. Fool them both by adding a unicode zero-width space into the text.

Co-authored-by: Andy Salnikov <salnikov@slac.stanford.edu>

Fixes about 200 errors in nitpick mode.

timj requested a review from andy-slac July 5, 2023 20:37

andy-slac approved these changes Jul 5, 2023

View reviewed changes

timj and others added 14 commits July 5, 2023 15:45

Stop using pytest-flake8

f04a859

Apply automated doc fixes

afe12f3

Move module docstring to top of file

660df3a

Fix spelling

793fa79

Add N804 noqa flag

401ba57

ruff seems to be getting confused and is insisting that __len__ and __iter__ are class methods and so should not use "self".

Use ruff instead of flake8 in pre-commit

02a279f

Fool ruff and pydocstyle into accepting "parameters"

161f86f

Neither ruff nor pydocstyle understand that "parameters:" in a code-block in a docstring is not in fact a numpydoc Parameters directive that has gone wrong. Fool them both by adding a unicode zero-width space into the text.

Use ruff configuration that agrees with other middleware packages

9f350b7

Fix docstyle problems, mostly in tests

8951f2d

Add ruff to lint action

c4a245a

Add pipelines.lsst.io to intersphinx

c643cfd

Use newer documenteer for sphinx build action

1afe716

Minor docstring fixes from code review

1f63761

Co-authored-by: Andy Salnikov <salnikov@slac.stanford.edu>

Some cleanups to docstrings for sphinx

fb1d12a

Fixes about 200 errors in nitpick mode.

timj force-pushed the tickets/DM-39857 branch from 4a14897 to fb1d12a Compare July 5, 2023 22:45

Modernize type annotations in examples

590180b

timj merged commit 566bdaa into main Jul 6, 2023
11 of 12 checks passed

timj deleted the tickets/DM-39857 branch July 6, 2023 01:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DM-39857: Stop using pytest-flake8 and add ruff config #353

DM-39857: Stop using pytest-flake8 and add ruff config #353

timj commented Jul 5, 2023

codecov bot commented Jul 5, 2023 •

edited

andy-slac left a comment

DM-39857: Stop using pytest-flake8 and add ruff config #353

DM-39857: Stop using pytest-flake8 and add ruff config #353

Conversation

timj commented Jul 5, 2023

Checklist

codecov bot commented Jul 5, 2023 • edited

Codecov Report

andy-slac left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 5, 2023 •

edited