DM-39944: Update Execution butler builder to use Butler._registry #355
Conversation
I hope execution butler will disappear sooner that we need to change this to something else.
| @@ -240,7 +240,7 @@ def _export(butler: Butler, collections: Iterable[str] | None, inserts: DataSetT | |||
| # export/import | |||
| BackendClass = get_class_of(butler._config["repo_transfer_formats", "yaml", "export"]) | |||
| backend = BackendClass(yamlBuffer, universe=butler.dimensions) | |||
| exporter = RepoExportContext(butler.registry, butler._datastore, backend, directory=None, transfer=None) | |||
| exporter = RepoExportContext(butler._registry, butler._datastore, backend, directory=None, transfer=None) | |||
There was a problem hiding this comment.
It is looking suspiciously like RepoExportContext is not a public API...
There was a problem hiding this comment.
I think its instantiation is intended to happen inside Butler.export(), but execution butler does not like to use export() for some reason. I prefer to wait until we remove execution butler rather than fixing it.
There was a problem hiding this comment.
I consider everything but construction of RepoExportContext to be public API, but construction definitely is not.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 82.73% 82.70% -0.03%
==========================================
Files 66 66
Lines 7268 7268
Branches 1418 1418
==========================================
- Hits 6013 6011 -2
- Misses 1007 1008 +1
- Partials 248 249 +1
☔ View full report in Codecov by Sentry. |
|
Sorry about the ruff problem. Not sure how I committed such a broken noqa statement last time. |
andy-slac
force-pushed
the
tickets/DM-39944
branch
from
1b073ad
to
c73e4ff
Compare
| @@ -240,7 +240,7 @@ def _export(butler: Butler, collections: Iterable[str] | None, inserts: DataSetT | |||
| # export/import | |||
| BackendClass = get_class_of(butler._config["repo_transfer_formats", "yaml", "export"]) | |||
| backend = BackendClass(yamlBuffer, universe=butler.dimensions) | |||
| exporter = RepoExportContext(butler.registry, butler._datastore, backend, directory=None, transfer=None) | |||
| exporter = RepoExportContext(butler._registry, butler._datastore, backend, directory=None, transfer=None) | |||
There was a problem hiding this comment.
I consider everything but construction of RepoExportContext to be public API, but construction definitely is not.
andy-slac
force-pushed
the
tickets/DM-39944
branch
2 times, most recently
from
daf4772
to
3517803
Compare
Depends on lsst/daf_butler#864
Checklist
doc/changes