Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40002: Support pydantic v2 #357

Merged
merged 6 commits into from Jul 19, 2023
Merged

DM-40002: Support pydantic v2 #357

merged 6 commits into from Jul 19, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jul 18, 2023

Requires lsst/daf_butler#866

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (3517803) 82.70% compared to head (cc509f0) 82.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   82.70%   82.75%   +0.05%     
==========================================
  Files          66       66              
  Lines        7268     7255      -13     
  Branches     1418     1301     -117     
==========================================
- Hits         6011     6004       -7     
+ Misses       1008     1002       -6     
  Partials      249      249              
Impacted Files Coverage Δ
python/lsst/pipe/base/_task_metadata.py 97.57% <100.00%> (+0.93%) ⬆️
python/lsst/pipe/base/graph/quantumNode.py 85.96% <100.00%> (+1.34%) ⬆️
...ython/lsst/pipe/base/tests/mocks/_storage_class.py 51.77% <100.00%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 32b72e6 into main Jul 19, 2023
14 checks passed
@timj timj deleted the tickets/DM-40002 branch July 19, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants