Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40032: Add missing stacklevel param and remove deprecated code #360

Merged
merged 6 commits into from Aug 3, 2023
Merged

DM-40032: Add missing stacklevel param and remove deprecated code #360

merged 6 commits into from Aug 3, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jul 28, 2023 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited

Codecov Report

Patch coverage: 76.66% and project coverage change: +0.12% 🎉

Comparison is base (496a576) 82.59% compared to head (1aa3c80) 82.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   82.59%   82.72%   +0.12%     
==========================================
  Files          66       66              
  Lines        7349     7345       -4     
  Branches     1443     1443              
==========================================
+ Hits         6070     6076       +6     
+ Misses       1031     1023       -8     
+ Partials      248      246       -2
Files Changed Coverage Δ
python/lsst/pipe/base/graph/graph.py 84.44% <25.00%> (+1.23%) ⬆️
python/lsst/pipe/base/_datasetQueryConstraints.py 70.58% <50.00%> (+0.43%) ⬆️
python/lsst/pipe/base/_task_metadata.py 99.02% <100.00%> (+1.45%) ⬆️
python/lsst/pipe/base/pipelineIR.py 85.39% <100.00%> (+0.03%) ⬆️
tests/test_task.py 97.31% <100.00%> (ø)
tests/test_taskmetadata.py 98.75% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj
Clean up the TaskMetadata.names() topLevelOnly deprecation
8fbcfa0 
We should have been able to remove the parameter by now but
this was made difficult by us still allowing code to use
it without warning.
@timj
Remove pickle support
9742ff2 
Deprecated for a long time.
@timj
Add stacklevel to warnings
9d79499
@timj timj requested a review from TallJimbo August 3, 2023 14:49
@timj timj merged commit eb4b848 into main Aug 3, 2023
13 of 14 checks passed
@timj timj deleted the tickets/DM-40032 branch August 3, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo