DM-40303: Fix pydantic v2 warnings #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 83.97% 84.18% +0.21%
==========================================
Files 77 77
Lines 9086 9070 -16
Branches 1741 1739 -2
==========================================
+ Hits 7630 7636 +6
+ Misses 1166 1145 -21
+ Partials 290 289 -1
☔ View full report in Codecov by Sentry. |
Dict and Pydantic have different APIs when using a method but copy.copy() works with both.
timj
commented
Aug 4, 2023
timj
commented
Aug 4, 2023
| @@ -97,7 +98,7 @@ def run(self, input: TaskMetadata | dict[str, int]) -> Struct: # type: ignore | |||
| Struct with a single ``output`` attribute. | |||
| """ | |||
| self.log.info("Run method given data of type: %s", get_full_type_name(input)) | |||
| output = input.copy() | |||
| output = copy.copy(input) | |||
There was a problem hiding this comment.
This is tested by ctrl_mpexec.
andy-slac
approved these changes
Aug 4, 2023
This is in a metaclass and so mypy does not really know what the class is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes