Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40330: Fix counting of elements in loop #365

Merged
merged 2 commits into from Aug 7, 2023
Merged

DM-40330: Fix counting of elements in loop #365

merged 2 commits into from Aug 7, 2023

Conversation

timj
Copy link
Member

@timj timj commented Aug 7, 2023

Previously enumerate() was used in the loop as a proxy counter but this was removed mistakenly when ruff complained that the counter wasn't being used. Replace the logic with an explicit counter so people don't get confused again.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Previously enumerate() was used in the loop as a proxy counter
but this was removed mistakenly when ruff complained that the
counter wasn't being used. Replace the logic with an explicit
counter so people don't get confused again.
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.15% ⚠️

Comparison is base (d1bbb55) 84.23% compared to head (0e05001) 84.09%.

❗ Current head 0e05001 differs from pull request most recent head 2712915. Consider uploading reports for the commit 2712915 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   84.23%   84.09%   -0.15%     
==========================================
  Files          77       77              
  Lines        9070     9071       +1     
  Branches     1739     1739              
==========================================
- Hits         7640     7628      -12     
- Misses       1143     1157      +14     
+ Partials      287      286       -1     
Files Changed Coverage Δ
python/lsst/pipe/base/graphBuilder.py 61.53% <66.66%> (-1.78%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj requested a review from TallJimbo August 7, 2023 16:22
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. With the benefit of hindsight this is much clearer.

We have not had daily for a while and they have disappeared.
@timj timj merged commit 82993db into main Aug 7, 2023
12 checks passed
@timj timj deleted the tickets/DM-40330 branch August 7, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants