DM-40842: Fix error message about dataset type consistency in pipeline graph resolution #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
changed the title
natelust
force-pushed
the
tickets/DM-40842
branch
from
238ce6d
to
ca6da6a
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 82.28% 82.26% -0.02%
==========================================
Files 90 90
Lines 10184 10184
Branches 1913 1913
==========================================
- Hits 8380 8378 -2
- Misses 1477 1478 +1
- Partials 327 328 +1
☔ View full report in Codecov by Sentry. |
TallJimbo
changed the title
TallJimbo
approved these changes
Sep 21, 2023
The exception message when checking dataset types in a pipeline against known definitions in the registry had the variables swapped in the exception message, fixed in this commit.
natelust
force-pushed
the
tickets/DM-40842
branch
from
ca6da6a
to
34cded8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes