Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41116: Few updates fiollowing Butler interface change #378

Merged
merged 1 commit into from Oct 18, 2023

Conversation

andy-slac
Copy link
Contributor

Butler is now an abstract class, and preferred way to instantiate butlers
is Butler.from_config. Execution butler requires a DirectButler instance,
updated type annotations to reflect that.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e1cb22b) 82.46% compared to head (d715696) 82.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   82.46%   82.47%           
=======================================
  Files          92       92           
  Lines       10346    10350    +4     
  Branches     1951     1951           
=======================================
+ Hits         8532     8536    +4     
  Misses       1472     1472           
  Partials      342      342           
Files Coverage Δ
python/lsst/pipe/base/executionButlerBuilder.py 66.44% <100.00%> (+0.22%) ⬆️
python/lsst/pipe/base/tests/simpleQGraph.py 71.42% <100.00%> (ø)
tests/test_executionButler.py 100.00% <100.00%> (ø)
python/lsst/pipe/base/pipeline_graph/__main__.py 0.00% <0.00%> (ø)
...ython/lsst/pipe/base/script/register_instrument.py 50.00% <0.00%> (ø)
...ython/lsst/pipe/base/script/transfer_from_graph.py 12.50% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Butler is now an abstract class, and preferred way to instanciate butlers
is `Butler.from_config`. Execution butler requires a `DirectButler` instance,
updated type annotations to reflect that.
@andy-slac andy-slac merged commit d943e6a into main Oct 18, 2023
13 of 14 checks passed
@andy-slac andy-slac deleted the tickets/DM-41116 branch October 18, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants