DM-41191: fix mocking bugs involving automatic-output connections #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Oct 16, 2023
| data ID match using the butler expression language (i.e. a string of | ||
| the sort passed ass the ``where`` argument to butler query methods), | ||
| while the second is the type of exception to raise when the quantum | ||
| data ID matches the expression. |
There was a problem hiding this comment.
What is the meaning of None for exception type?
There was a problem hiding this comment.
Had to remind myself since I just copied this from mock_task_defs, but the answer is that it's just a way to make it easy to invoke the default of ValueError, which is defined down in the MockPipelineTaskConfig. Will document.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 82.62% 82.46% -0.16%
==========================================
Files 92 92
Lines 10323 10346 +23
Branches 1945 1951 +6
==========================================
+ Hits 8529 8532 +3
- Misses 1452 1472 +20
Partials 342 342
☔ View full report in Codecov by Sentry. |
This will replace mock_task_defs in the future.
Automatic-output connections (configs, logs, metadata) get _mock prefixes from the task label, but don't actually use mock storage classes.
TallJimbo
force-pushed
the
tickets/DM-41191
branch
from
1391746
to
61de32b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes