Exit to the shell with the number of failed dataRefs #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Jul 20, 2017
python/lsst/pipe/base/cmdLineTask.py
Outdated
| @@ -369,12 +373,16 @@ def __call__(self, args): | |||
| self.log.MDC("LABEL", str([ref.dataId for ref in dataRef if hasattr(ref, "dataId")])) | |||
| task = self.makeTask(args=args) | |||
| result = None # in case the task fails | |||
| exitStatus = 0 # exit status for the shell | |||
There was a problem hiding this comment.
Picky: code standards say two spaces between the functional end of the line and the comment.
| if self.doRaise: | ||
| result = task.run(dataRef, **kwargs) | ||
| else: | ||
| try: | ||
| result = task.run(dataRef, **kwargs) | ||
| except Exception as e: | ||
| exitStatus = 1 # n.b. The shell exit value is the number of dataRefs returning | ||
| # non-zero, so the actual value used here is lost |
There was a problem hiding this comment.
Not sure what code standards say about trailing multiline comments, but I'm gonna guess they want two spaces between the end of the functional part and the start of the comment.
python/lsst/pipe/base/cmdLineTask.py
Outdated
| try: | ||
| nFailed = sum(((res.exitStatus != 0) for res in resultList)) | ||
| except Exception as e: | ||
| parsedCmd.log.warn("Unable to retrieve exit status (%s); assuming success" % e) |
There was a problem hiding this comment.
Probably not important in this context, but in general you shouldn't use % to expand the string but separate with commas:
parsedCmd.log.warn("Unable to retrieve exit status (%s); assuming success", e)
(Another below).
| @@ -347,6 +347,8 @@ def __init__(self, name, usage="%(prog)s input [options]", **kwargs): | |||
| self.add_argument("--debug", action="store_true", help="enable debugging output?") | |||
| self.add_argument("--doraise", action="store_true", | |||
| help="raise an exception on error (else log a message and continue)?") | |||
| self.add_argument("--noExit", action="store_true", | |||
| help="Do not exit even upon failure (i.e. return a struct to the bin script)") | |||
There was a problem hiding this comment.
Maybe don't assume that the caller's a "bin script"?
Can be overridden using --noExit
RobertLuptonTheGood
force-pushed
the
tickets/DM-4141
branch
from
a09b5fd
to
2903ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be overridden using --noExit