DM-41235: Update test to use SqlRegistry instead of Registry #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 82.49% 82.47% -0.02%
==========================================
Files 92 92
Lines 10350 10351 +1
Branches 1951 1951
==========================================
- Hits 8538 8537 -1
- Misses 1471 1472 +1
- Partials 341 342 +1
☔ View full report in Codecov by Sentry. |
timj
approved these changes
Oct 25, 2023
| @@ -205,7 +206,7 @@ def test_dimension_packer_config_defaults(self): | |||
| """ | |||
| registry_config = RegistryConfig() | |||
| registry_config["db"] = "sqlite://" | |||
| registry = Registry.createFromConfig(registry_config) | |||
| registry = SqlRegistry.createFromConfig(registry_config) | |||
| self.instrument.register(registry) | |||
There was a problem hiding this comment.
I suppose all our Instrument APIs are going to have to switch to using a Butler in the future.
andy-slac
force-pushed
the
tickets/DM-41235
branch
from
d20fc00
to
1f509c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/daf_butler#898
Checklist
doc/changes