Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41321: Add try-except block to manifest checker so that failure to get butler logs does not make error reporting impossible #384

Merged
merged 2 commits into from Nov 7, 2023

Conversation

eigerx
Copy link
Contributor

@eigerx eigerx commented Nov 1, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@eigerx eigerx changed the title Tickets/dm 41321 DM-41321: Add try-except block to manifest checker so that failure to get butler logs does not make error reporting impossible Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0a17352) 82.47% compared to head (e084f20) 82.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   82.47%   82.43%   -0.04%     
==========================================
  Files          92       92              
  Lines       10354    10356       +2     
  Branches     1952     1953       +1     
==========================================
- Hits         8539     8537       -2     
- Misses       1473     1476       +3     
- Partials      342      343       +1     
Files Coverage Δ
tests/test_execution_reports.py 100.00% <100.00%> (ø)
python/lsst/pipe/base/execution_reports.py 75.00% <50.00%> (-1.23%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

try:
log = butler.get(log_ref)
except LookupError:
quantum_info["error"] = []
except FileNotFoundError:
quantum_info["error"] = None
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth printing a message here that you did miss some files just so people know that it happened, unless that's dealt with elsewhere.

@eigerx eigerx merged commit 58cb176 into main Nov 7, 2023
12 of 14 checks passed
@eigerx eigerx deleted the tickets/DM-41321 branch November 7, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants