New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-42302: Drop support for Pydantic v1. #396
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 82.51% 82.25% -0.26%
==========================================
Files 92 92
Lines 10430 10460 +30
Branches 1971 1977 +6
==========================================
- Hits 8606 8604 -2
- Misses 1483 1511 +28
- Partials 341 345 +4 ☔ View full report in Codecov by Sentry. |
4869db0
to
f190189
Compare
I have no idea why the doc build is trying to build docs for Pydantic itself (that seems to be what it's failing on), or why it's a problem here but not in daf_butler. |
49e2508
to
a512a07
Compare
I've added some trivial forwarders to public classes that inherit from It's hard for me to believe that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sphinx fixes are pretty bad but seem pragmatic for now.
This version claims to be compatible with Pydantic v2 and it works for daf_butler, though there are reasons to doubt it's fully compatible.
This isn't pretty at all, but I have yet to find another way.
a8ee722
to
473a15e
Compare
Requires lsst/daf_butler#929
Checklist
doc/changes