DM-42301: Make calibration-lookup logic less restrictive.

[TallJimbo]

Logic in the prerequisite finders that was expecting a regular calibration lookup was not correctly handling cases where the task did not have temporal dimensions even though the dataset was a calibration; it was raising exceptions even though falling through to findDataset or queryDatasets calls would have worked just fine.

Checklist

• ran Jenkins
• added a release note for user-visible changes to doc/changes

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (572f9e4) 82.45% compared to head (dbf04c1) 82.43%.

❗ Current head dbf04c1 differs from pull request most recent head e880417. Consider uploading reports for the commit e880417 to get more accurate results

Files	Patch %	Lines
python/lsst/pipe/base/prerequisite_helpers.py	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   82.45%   82.43%   -0.02%     
==========================================
  Files          91       91              
  Lines       10414    10414              
  Branches     1964     1964              
==========================================
- Hits         8587     8585       -2     
- Misses       1485     1486       +1     
- Partials      342      343       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[timj]

Looks okay. Do we know that ci_middleware exercises this code?

[TallJimbo]

ci_middleware exercises most of the logic branches in PrerequisiteFinders, but not all of them, and I know for a fact that it doesn't exercise the bug that spawned this ticket, though ci_cpp might. I just can't prioritize adding CPP-like data and tasks to ci_middleware right now.

Some of the other branches cannot actually be exercised since we only have one concrete QuantumGraphBuilder implementation class and that does optimized versions of some of those branches before they ever have a chance to fire. I figure currently-unreachable code that's probably correct is better than raising or asserting, but 🤷‍♂️?