Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42737: Switch back to butler.registry query system in QG generation. #401

Merged
merged 4 commits into from Feb 14, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Jan 31, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes (not user-visible)

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (a8697e8) 82.47% compared to head (6aea5bc) 82.46%.

Files Patch % Lines
.../pipe/base/all_dimensions_quantum_graph_builder.py 55.55% 3 Missing and 1 partial ⚠️
python/lsst/pipe/base/_task_metadata.py 0.00% 0 Missing and 2 partials ⚠️
...on/lsst/pipe/base/pipeline_graph/_mapping_views.py 0.00% 0 Missing and 2 partials ⚠️
python/lsst/pipe/base/quantum_graph_builder.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   82.47%   82.46%   -0.01%     
==========================================
  Files          91       91              
  Lines       10471    10467       -4     
  Branches     1982     1984       +2     
==========================================
- Hits         8636     8632       -4     
+ Misses       1489     1485       -4     
- Partials      346      350       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is temporarily switching back to butler.registry can you say that in the commit message with a reason?

This is temporary; the switch to the new system was premature, but is
still in the works.
It's disagreeing with black again, and with both black and ruff on,
we don't need it.
@TallJimbo
Copy link
Member Author

Commit message has been updated.

@TallJimbo TallJimbo merged commit a71a70a into main Feb 14, 2024
11 of 13 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-42737 branch February 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants