DM-42928: Add methods to get and set nested dictionaries from TaskMetadata #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 82.48% 82.50% +0.01%
==========================================
Files 91 91
Lines 10467 10498 +31
Branches 1984 1987 +3
==========================================
+ Hits 8634 8661 +27
- Misses 1484 1485 +1
- Partials 349 352 +3 ☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-42928
branch
2 times, most recently
from
f77910f
to
a5a6846
Compare
The methods here are trivial, but the PropertyList implementation is not, and it's the consistency between all three types (TaskMetadata, PropertyList, and PropertySet) that's really the value added here.
TallJimbo
force-pushed
the
tickets/DM-42928
branch
from
a5a6846
to
ecb25ba
Compare
timj
approved these changes
Feb 20, 2024
| dictionary into these objects that avoids their historical idiosyncrasies. | ||
|
|
||
| The form in which these entries appear in the object's native keys and | ||
| values is implementation-defined. *Empty nested dictionaries *may* be |
There was a problem hiding this comment.
This nesting of markup doesn't work in sphinx.
| @@ -56,6 +60,41 @@ def _isListLike(v: Any) -> bool: | |||
| return isinstance(v, Sequence) and not isinstance(v, str) | |||
|
|
|||
|
|
|||
| class SetDictMetadata(Protocol): | |||
There was a problem hiding this comment.
Could there be a single DictMetadata protocol that has both in?
| `float`, `str`, `bool`, or another `dict` with the same key and | ||
| value types. | ||
| """ | ||
| self[key] = TaskMetadata.from_dict(value) |
There was a problem hiding this comment.
self[key] = valueshould work fine. The TaskMetadata.from_dict will be called later on.
This will be used shortly on DM-39842.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods here are trivial, but the PropertyList implementation is not, and it's the consistency between all three types (TaskMetadata, PropertyList, and PropertySet) that's really the value added here.
See also lsst/daf_base#82
Checklist
doc/changes