Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42954: Special-case component dataset types in execution reports. #404

Merged
merged 1 commit into from Feb 27, 2024

Conversation

timj
Copy link
Member

@timj timj commented Feb 20, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.42%. Comparing base (4b2da7a) to head (1a20438).

Files Patch % Lines
python/lsst/pipe/base/execution_reports.py 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   82.52%   82.42%   -0.10%     
==========================================
  Files          91       91              
  Lines       10498    10501       +3     
  Branches     1987     1989       +2     
==========================================
- Hits         8663     8655       -8     
- Misses       1484     1491       +7     
- Partials      351      355       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TallJimbo TallJimbo force-pushed the tickets/DM-42954 branch 3 times, most recently from 2217502 to c825188 Compare February 21, 2024 02:32
Copy link
Contributor

@eigerx eigerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on the same graph that had errors previously. Let me know if I can supply any more test cases.

@TallJimbo TallJimbo merged commit 14962cd into main Feb 27, 2024
11 of 13 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-42954 branch February 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants