Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43225: Save stack versions in QuantumGraph. #406

Merged
merged 1 commit into from Mar 26, 2024
Merged

Conversation

MichelleGower
Copy link
Contributor

@MichelleGower MichelleGower commented Mar 21, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.40%. Comparing base (7c47f2a) to head (83de5ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   82.36%   82.40%   +0.04%     
==========================================
  Files          93       93              
  Lines       10645    10647       +2     
  Branches     2021     2020       -1     
==========================================
+ Hits         8768     8774       +6     
+ Misses       1521     1519       -2     
+ Partials      356      354       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if self._metadata is not None:
metadata2 = dict(self._metadata)
metadata2["packages"] = Packages.fromSystem()
self._metadata = metadata2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you wrote is fine, but if you are now going to always be adding to the metadata now may I suggest:

self._metadata = dict(metadata) if metadata is not None else {}
Self._metadata[‘packages’] = Packages.fromSystem()

Fewer round trips and copies being made.

@MichelleGower MichelleGower force-pushed the tickets/DM-43225 branch 2 times, most recently from f674eb8 to a35c4d0 Compare March 26, 2024 02:06
@MichelleGower MichelleGower merged commit e08bb7a into main Mar 26, 2024
13 checks passed
@MichelleGower MichelleGower deleted the tickets/DM-43225 branch March 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants