Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43484: Add simulated OOM errors to PipelineTask mocks #408

Merged
merged 1 commit into from Mar 28, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Mar 27, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 82.38%. Comparing base (cf2952e) to head (660581d).

Files Patch % Lines
...ython/lsst/pipe/base/tests/mocks/_pipeline_task.py 44.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   82.38%   82.38%   -0.01%     
==========================================
  Files          93       93              
  Lines       10647    10661      +14     
  Branches     2020     2022       +2     
==========================================
+ Hits         8772     8783      +11     
- Misses       1520     1523       +3     
  Partials      355      355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TallJimbo TallJimbo force-pushed the tickets/DM-43484 branch 2 times, most recently from 5250096 to fbed95e Compare March 27, 2024 03:43
Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shouldn't there be a doc/changes file? Merge approved

@TallJimbo
Copy link
Member Author

I was thinking of the bugfix in ctrl_mpexec as the only "user-visible change" but upon further reflecting a changelog entry for the changes here wouldn't hurt.

@TallJimbo TallJimbo merged commit 697e81c into main Mar 28, 2024
11 of 13 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-43484 branch March 28, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants