Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40441: first batch of deprecations from RFC-949 #411

Merged
merged 31 commits into from
Apr 8, 2024
Merged

Commits on Mar 29, 2024

  1. Remove mock_task_defs.

    This was added _just_ before TaskDef was approved for deprecation on
    RFC-949, and I'm sure nothing outside ctrl_mpexec is using it, so I'm
    not going through a deprecation period for it.
    TallJimbo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    15b6430 View commit details
    Browse the repository at this point in the history
  2. Allow datastore records not to be attached in new QG builder.

    After DM-38498 datastore records were mistakenly being attached whether
    requested or not.
    TallJimbo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    94e5e53 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    765bd41 View commit details
    Browse the repository at this point in the history
  4. Export DatasetQueryConstraintVariant symbol.

    Apparently this was only exported publicly by the graphBuilder module,
    and while that was sort of an accident (it wasn't in __all__), it also
    makes sense as the only code using it, and that makes
    all_dimensions_quantum_graph_builder the logical new home.
    TallJimbo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9eae693 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09b65da View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Add pipeline_graph attribute to QuantumGraph.

    Eventually (DM-40442) these classes will be more tightly integrated,
    but this piece lets us start to modernize downstream code in advance.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    f5eed06 View commit details
    Browse the repository at this point in the history
  2. Add task_node property to QuantumNode.

    Like the pipeline_graph attribute of QuantumGraph, eventually
    (DM-40442) we'll want this to be more tightly integrated, probably
    replacing the TaskDef as the true attribute, but for now this is enough
    to allow downstream code to be more forward-looking by avoiding
    deprecated or soon-to-be-deprecated TaskDef interfaces.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2ed8193 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1622165 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0f891a2 View commit details
    Browse the repository at this point in the history
  5. Use config-instance connections type, not task.ConfigClass.

    Passing a subclass instance of Task.ConfigClass is a weird thing to do,
    but it's seems harder to prohibit it than just accept it, and we have
    some tests in ctrl_mpexec that depend on doing just that.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5570b1a View commit details
    Browse the repository at this point in the history
  6. Make TaskFactory take TaskNode, and deprecate it taking TaskDef.

    This also makes the first argument to TaskFactory.makeTask
    positional-only, which is formally backwards incompatible but not
    something I'm worried about in practice.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b8d172e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    79781e5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cfe3eef View commit details
    Browse the repository at this point in the history
  9. Add TaskNode.get_connections.

    I originally hoped we could minimize how much of the
    PipelineTaskConnections interface PipelineGraph would have to expose,
    with the idea being that PipelineTaskConnections would be one interface
    that task authors write to, and TaskNode would be a slightly different
    interface that the execution system writes against, and that decoupling
    those would be good for stability.  But we've always had to punch holes
    to allow the task to customize its execution in various respects, and
    at this point it's best to just provide access to the connections class
    itself, too, even if we'd still prefer to have other TaskNode
    interfaces used by the execution system where possible.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    51d2d5f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7341707 View commit details
    Browse the repository at this point in the history
  11. Rewrite test_pipelineTask to use PipelineGraph.

    This was the last usage of BaseConnections.makeDatasetType, so we can
    deprecate it now.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2347bd4 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9718ac7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e4701c9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2675e05 View commit details
    Browse the repository at this point in the history
  15. Reimplement Pipeline label-range slicing via PipelineGraph.

    This also solidifies the definition of what we mean by label-range
    slicing for task that lack a dependency relationship to one or both
    bounds.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    21a8f6d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    95b270f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6e685f0 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    78ea4c7 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    399c5eb View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    db004ca View commit details
    Browse the repository at this point in the history
  21. Re-raise FieldValidationError when configuring tasks.

    FieldValidationError has more useful state for diagonstics than most
    other exceptions, and that's worth preserving when validation fails.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6979b25 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    46fac74 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    55921fd View commit details
    Browse the repository at this point in the history
  24. Shift deprecation/removal release.

    v26 came and went while this branch was sidetracked.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b32c3ad View commit details
    Browse the repository at this point in the history
  25. Add Pipeline.task_labels property

    This provides a way to get the labels of the tasks without the
    expensive (and not-always-possible) step of making a PipelineGraph.
    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2160f0c View commit details
    Browse the repository at this point in the history
  26. Add changelog entry.

    TallJimbo committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b4cf9cf View commit details
    Browse the repository at this point in the history