-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-40441: first batch of deprecations from RFC-949 #411
Commits on Mar 29, 2024
-
This was added _just_ before TaskDef was approved for deprecation on RFC-949, and I'm sure nothing outside ctrl_mpexec is using it, so I'm not going through a deprecation period for it.
Configuration menu - View commit details
-
Copy full SHA for 15b6430 - Browse repository at this point
Copy the full SHA 15b6430View commit details -
Allow datastore records not to be attached in new QG builder.
After DM-38498 datastore records were mistakenly being attached whether requested or not.
Configuration menu - View commit details
-
Copy full SHA for 94e5e53 - Browse repository at this point
Copy the full SHA 94e5e53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 765bd41 - Browse repository at this point
Copy the full SHA 765bd41View commit details -
Export DatasetQueryConstraintVariant symbol.
Apparently this was only exported publicly by the graphBuilder module, and while that was sort of an accident (it wasn't in __all__), it also makes sense as the only code using it, and that makes all_dimensions_quantum_graph_builder the logical new home.
Configuration menu - View commit details
-
Copy full SHA for 9eae693 - Browse repository at this point
Copy the full SHA 9eae693View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09b65da - Browse repository at this point
Copy the full SHA 09b65daView commit details
Commits on Apr 8, 2024
-
Add pipeline_graph attribute to QuantumGraph.
Eventually (DM-40442) these classes will be more tightly integrated, but this piece lets us start to modernize downstream code in advance.
Configuration menu - View commit details
-
Copy full SHA for f5eed06 - Browse repository at this point
Copy the full SHA f5eed06View commit details -
Add task_node property to QuantumNode.
Like the pipeline_graph attribute of QuantumGraph, eventually (DM-40442) we'll want this to be more tightly integrated, probably replacing the TaskDef as the true attribute, but for now this is enough to allow downstream code to be more forward-looking by avoiding deprecated or soon-to-be-deprecated TaskDef interfaces.
Configuration menu - View commit details
-
Copy full SHA for 2ed8193 - Browse repository at this point
Copy the full SHA 2ed8193View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1622165 - Browse repository at this point
Copy the full SHA 1622165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f891a2 - Browse repository at this point
Copy the full SHA 0f891a2View commit details -
Use config-instance connections type, not task.ConfigClass.
Passing a subclass instance of Task.ConfigClass is a weird thing to do, but it's seems harder to prohibit it than just accept it, and we have some tests in ctrl_mpexec that depend on doing just that.
Configuration menu - View commit details
-
Copy full SHA for 5570b1a - Browse repository at this point
Copy the full SHA 5570b1aView commit details -
Make TaskFactory take TaskNode, and deprecate it taking TaskDef.
This also makes the first argument to TaskFactory.makeTask positional-only, which is formally backwards incompatible but not something I'm worried about in practice.
Configuration menu - View commit details
-
Copy full SHA for b8d172e - Browse repository at this point
Copy the full SHA b8d172eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79781e5 - Browse repository at this point
Copy the full SHA 79781e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfe3eef - Browse repository at this point
Copy the full SHA cfe3eefView commit details -
I originally hoped we could minimize how much of the PipelineTaskConnections interface PipelineGraph would have to expose, with the idea being that PipelineTaskConnections would be one interface that task authors write to, and TaskNode would be a slightly different interface that the execution system writes against, and that decoupling those would be good for stability. But we've always had to punch holes to allow the task to customize its execution in various respects, and at this point it's best to just provide access to the connections class itself, too, even if we'd still prefer to have other TaskNode interfaces used by the execution system where possible.
Configuration menu - View commit details
-
Copy full SHA for 51d2d5f - Browse repository at this point
Copy the full SHA 51d2d5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7341707 - Browse repository at this point
Copy the full SHA 7341707View commit details -
Rewrite test_pipelineTask to use PipelineGraph.
This was the last usage of BaseConnections.makeDatasetType, so we can deprecate it now.
Configuration menu - View commit details
-
Copy full SHA for 2347bd4 - Browse repository at this point
Copy the full SHA 2347bd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9718ac7 - Browse repository at this point
Copy the full SHA 9718ac7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4701c9 - Browse repository at this point
Copy the full SHA e4701c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2675e05 - Browse repository at this point
Copy the full SHA 2675e05View commit details -
Reimplement Pipeline label-range slicing via PipelineGraph.
This also solidifies the definition of what we mean by label-range slicing for task that lack a dependency relationship to one or both bounds.
Configuration menu - View commit details
-
Copy full SHA for 21a8f6d - Browse repository at this point
Copy the full SHA 21a8f6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95b270f - Browse repository at this point
Copy the full SHA 95b270fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e685f0 - Browse repository at this point
Copy the full SHA 6e685f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78ea4c7 - Browse repository at this point
Copy the full SHA 78ea4c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 399c5eb - Browse repository at this point
Copy the full SHA 399c5ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for db004ca - Browse repository at this point
Copy the full SHA db004caView commit details -
Re-raise FieldValidationError when configuring tasks.
FieldValidationError has more useful state for diagonstics than most other exceptions, and that's worth preserving when validation fails.
Configuration menu - View commit details
-
Copy full SHA for 6979b25 - Browse repository at this point
Copy the full SHA 6979b25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46fac74 - Browse repository at this point
Copy the full SHA 46fac74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55921fd - Browse repository at this point
Copy the full SHA 55921fdView commit details -
Shift deprecation/removal release.
v26 came and went while this branch was sidetracked.
Configuration menu - View commit details
-
Copy full SHA for b32c3ad - Browse repository at this point
Copy the full SHA b32c3adView commit details -
Add Pipeline.task_labels property
This provides a way to get the labels of the tasks without the expensive (and not-always-possible) step of making a PipelineGraph.
Configuration menu - View commit details
-
Copy full SHA for 2160f0c - Browse repository at this point
Copy the full SHA 2160f0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b4cf9cf - Browse repository at this point
Copy the full SHA b4cf9cfView commit details