DM-11931 Cleanup exitStatus handling #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
approved these changes
Oct 25, 2017
|
|
||
| If ``doReturnResults`` is `False` the struct contains: | ||
|
|
||
| - ``exitStatus``. | ||
| - ``exitStatus`: 0 if the task completed successfully, 1 otherwise. |
There was a problem hiding this comment.
Reading DM-4141 here it's not "1 otherwise" but "a non-zero value the number of failed dataRefs is passed". Do I read that correctly?
There was a problem hiding this comment.
For __call__, I believe my statement is correct (at least, it matches what the code in that method does). parseAndRun is what does what you say.
@RobertLuptonTheGood can confirm that this was his intention.
There was a problem hiding this comment.
I think that I intended to return 1 here. As @parejkoj says, parseAndRun adds up the error codes, so it returns the number of failed dataRefs
parejkoj
force-pushed
the
tickets/DM-11931
branch
from
c217440
to
15478ea
Compare
parejkoj
force-pushed
the
tickets/DM-11931
branch
from
15478ea
to
eb529c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.