Add tests of DataIdContainer and improve exception handling #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-15158
branch
from
6c59a8e
to
c1b9e7f
Compare
r-owen
approved these changes
Jul 19, 2018
| raise KeyError("Cannot get keys for datasetType %s at level %s" % (self.datasetType, self.level)) | ||
| except KeyError as e: | ||
| msg = "Cannot get keys for datasetType %s at level %s: %s" % (self.datasetType, self.level) | ||
| raise KeyError(msg) from e |
| # This product includes software developed by the LSST Project | ||
| # (https://www.lsst.org). | ||
| # See the COPYRIGHT file at the top-level directory of this distribution | ||
| # for details of code ownership. |
There was a problem hiding this comment.
Please add the COPYRIGHT file (or change this not to reference it)
There was a problem hiding this comment.
@timj came up with a list of things to put in that file. I don't think that process will scale for any other packages that we add new files to...
@timj did some quick history digging to come up with this list.
parejkoj
force-pushed
the
tickets/DM-15158
branch
from
6e42790
to
79dca0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving test coverage through improved testing!