Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple unit test of struct construction exception #55

Merged
merged 1 commit into from Jul 19, 2018

Conversation

isullivan
Copy link
Contributor

No description provided.

Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. One small request.

@@ -49,6 +49,12 @@ def testInit(self):
for name, val in self.valDict.items():
self.assertEqual(getattr(s, name), val)

def testInitException(self):
"""Test Struct.__init__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a more informative description, something along the lines of "test that names cannot start with __" or "test Struct constructor errors"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.. yes I forgot to update that description!

@isullivan isullivan merged commit 53a6ac1 into master Jul 19, 2018
@ktlim ktlim deleted the tickets/DM-15159 branch August 25, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants