tickets/DM-16904 #71
Merged
tickets/DM-16904 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Dec 19, 2018
| @@ -499,7 +499,7 @@ def makeDataRefs(descriptors, refMap): | |||
| outputDataIds, outputDataRefs = makeDataRefs(descriptors, quantum.outputs) | |||
|
|
|||
| # call run method with keyword arguments | |||
| struct = self.adaptArgsAndRun(inputs, inputDataIds, outputDataIds) | |||
| struct = self.adaptArgsAndRun(inputs, inputDataIds, outputDataIds, butler) | |||
There was a problem hiding this comment.
This is not yours, but should we fix the bad indentation a few lines up? (Compare 498 and 499 - I'm surprised Python isn't complaining about this, unless it's a GitHub artifact).
There was a problem hiding this comment.
Nevermind. Looks like it's a GitHub diff artifact.
natelust
force-pushed
the
tickets/DM-16904
branch
from
88c7cdd
to
9fec639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add butler to adaptArgsAndRun