DM-17042: Improve parsing of config overrides #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Jan 8, 2019
| try: | ||
| value = eval(value, {}) | ||
| # use safer ast.literal_eval, it only supports literals | ||
| value = ast.literal_eval(value) | ||
| except Exception: | ||
| # Something weird happened here, try passing, and seeing if further | ||
| # code can handle this |
There was a problem hiding this comment.
This comment block now makes no sense with the behavior below.
There was a problem hiding this comment.
👍 I will rephrase that
|
|
||
| # values of supported type | ||
| self.checkSingleFieldOverride(field, ["a", "b"], ["a", "b"]) | ||
|
|
There was a problem hiding this comment.
Does this implicitly support tuple if it was supplied? otherwise that might be a good test for parseable but invalid input
There was a problem hiding this comment.
Tuple (or any iterable) is supported by ListField, I'll try to add something for parseable but invalid.
andy-slac
force-pushed
the
tickets/DM-17042
branch
from
102b877
to
69a55e6
Compare
If string is passed as a field value but field has non-string type then we convert string to Python object using `ast.literal_eval`. Unit tests for various field types added as well.
andy-slac
force-pushed
the
tickets/DM-17042
branch
from
69a55e6
to
15eb9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If string is passed as a field value but field has non-string type then
we convert string to Python object using
ast.literal_eval. Unit testsfor various field types added as well.