tickets/DM-14819 #79
Merged
tickets/DM-14819 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
force-pushed
the
tickets/DM-14819
branch
from
308f1ea
to
b2e04b2
Compare
TallJimbo
approved these changes
Jan 17, 2019
python/lsst/pipe/base/config.py
Outdated
| manualLoad = pexConfig.Field(dtype=bool, | ||
| default=False, | ||
| optional=True, | ||
| doc=("If this is set to True, the class intendes to load " |
| @@ -337,6 +337,7 @@ def _dataRefKey(dataRef): | |||
| for key in dataRefs.keys(): | |||
| if dataRefs[key].id is not None: | |||
| dataRefs[key] = self.registry.getDataset(dataRefs[key].id) | |||
| self.registry.expandDataId(dataRefs[key].dataId, region=True) | |||
There was a problem hiding this comment.
Should make this one-liner a separate commit, with a message like:
Ensure metadata and regions are expanded in QuantumGraph data IDs.
This is a workaround for DM-17231.
b2e04b2
to
2bab211
Compare
Make sure the QuantumGraph and DataIds have their metadata and regions expanded. This is a workaround for DM-17231.
Although DatasetTypes need to be known prior to task execution to build a QuantumGraph, not all data products need to be loaded before task execution. This change introduces a way to indicate a DatasetType will be manually read in and handled by a task.
natelust
force-pushed
the
tickets/DM-14819
branch
from
2bab211
to
89d9b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow DatasetType to be marked for later load
Although DatasetTypes need to be known prior to task execution to
build a QuantumGraph, not all data products need to be loaded before
task execution. This change introduces a way to indicate a
DatasetType will be manually read in and handled by a task.