DM-17741: Improve logging forwarding setup #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous assumption that root logger has no handlers does not hold in case of pytest, resulting in a lot of messages generated by unit test. Fix is to set default logging level for root logger to INFO (like for lsst.log) and then adjust levels for individual loggers in sync for both lsst.log and logging.
andy-slac
changed the title
ktlim
reviewed
Feb 6, 2019
| # Python logging levels are same as lsst.log divided by 1000, | ||
| # logging does not have TRACE level by default but it is OK to use | ||
| # that numeric level and we may even add TRACE later. | ||
| logging.getLogger(component).setLevel(logLevel//1000) |
There was a problem hiding this comment.
We have LogHandler.translateLevel() to multiply by 1000; should we add a routine to divide by 1000 as well, since it appears here as well as in https://github.com/lsst/log/blob/master/python/lsst/log/log/logContinued.py#L123-L124 ?
There was a problem hiding this comment.
Yes, I though about that while reviewing Tim's ticket 🙂 I think I'll do it now, need to think where these two methods should be (either a module level method or in Log class or LogHandler)
andy-slac
force-pushed
the
tickets/DM-17741
branch
from
cb9c630
to
58a95de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous assumption that root logger has no handlers does not hold in
case of pytest, resulting in a lot of messages generated by unit test.
Fix is to set default logging level for root logger to INFO (like for
lsst.log) and then adjust levels for individual loggers in sync for both
lsst.log and logging.