Skip to content

Commit

Permalink
Address review comments. (Will be squashed before merge)
Browse files Browse the repository at this point in the history
  • Loading branch information
isullivan committed Jan 30, 2020
1 parent e253643 commit adf1306
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
2 changes: 0 additions & 2 deletions bin.src/makeGen3DcrSubfilters.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
# Build a parser for command line arguments
parser = argparse.ArgumentParser(description="Define the set of subfilters for chromatic modeling.")
parser.add_argument("butler", metavar="Butler", type=str, help="Path to a gen3 butler")
parser.add_argument("collection", type=str, metavar="Collection",
help="Name of the Butler collection the subfilters should be inserted into.")
parser.add_argument("-C", "--config-file", dest="configFile",
help="Path to a config file overrides file")

Expand Down
9 changes: 3 additions & 6 deletions python/lsst/pipe/tasks/makeGen3DcrSubfilters.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ class MakeGen3DcrSubfiltersConfig(pexConfig.Config):
default=3,
optional=False
)
filterName = pexConfig.Field(
doc="The filter to add chromatic subfilters to in the registry.",
filterName = pexConfig.ListField(
doc="The filters to add chromatic subfilters to in the registry.",
dtype=str,
default="g",
default=["g"],
optional=False
)

Expand All @@ -54,9 +54,6 @@ class MakeGen3DcrSubfiltersTask(pipeBase.Task):
config is created if value is None
"""

def __init__(self, *, config=None, **kwargs):
super().__init__(config=config, **kwargs)

def run(self, butler):
"""Construct a set of subfilters for chromatic modeling.
Parameters
Expand Down

0 comments on commit adf1306

Please sign in to comment.