pipe_tasks review for DM-1945: tasks for multi-band coadd processing #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @param exposure: Exposure to write out | ||
| @param results: Struct returned from runDetection | ||
| @param patchRef: data reference for patch |
There was a problem hiding this comment.
Should use """! here if using @param.
Forced photometry, if nothing else, requires the slots.
When these Tasks are run in their own stand-alone scripts, the schema is loaded through the butler. However, when they are run as part of a common operation, the Tasks are instantiated before the schemas are written out, and so they need to be given the schemas at construction time. This change makes both possible: the schema is used if provided, otherwise loaded from the butler. Conflicts: python/lsst/pipe/tasks/forcedPhotImage.py python/lsst/pipe/tasks/references.py
The SourceCatalog needs to be created with an IdFactory in the table so that sources added as part of the deblending have proper IDs. We exclude existing IDs from the IdFactory. Since the makeIdFactory method is identical, factor it out into a factory function (a factory factory).
This makes it easier to associate the configuration files in the obs_* package with the executable.
Matching may legitimately produce no matches (e.g., not large enough a lit area in the patch to contain any bright reference sources), so we don't want to raise an exception by writing zero matches.
Conflicts: python/lsst/pipe/tasks/multiBand.py
MergeSourcesTask's implementation was getting in the way of its subclasses a bit, by adding a field to the schema that they would not ultimately use. Since we're about to add a real implementation for MergeMeasurementTask, we can now remove the old default implementation without breaking the pipeline (at least not for very long). Fixup for removal for MergeSources default impl
We now use the measurement from the band the peak originated in, which means we're effectively using MergeDetectionTask's priority. Conflicts: python/lsst/pipe/tasks/multiBand.py
Merged data IDs don't include the filter, so printing them when writing them was mildly confusing.
As per https://confluence.lsstcorp.org/display/DM/S15+Multi-Band+Coadd+Processing+Prototype the DetectCoaddSourcesTask should output a calexp exposure with updated background and mask plane information. This was not being written, so this updates the task to write out the calibrated exposure. Note also that the name has been changed to coaddName + "calexp_det" to distinguish it from the "calexp" images output from processCoadd.py.
While the output from writeMatches is useful for debugging, it is not required. The default is being set to zero as, in its current configuration, it does not work as the astrometry task would have to be initiated (i.e. run) in order for the matcher to be instantiated. Changing the default back to True awaits a refactoring of the astrometry matching API.
Slots are copied automatically now, so this is no longer necessary.
Conflicts: python/lsst/pipe/tasks/multiBand.py
This originally went in MeasureCoaddSources because I thought we might want to sort peaks different in different bands (because they have different fluxes in different bands) - but we can't do that because we require the ordering of peaks to be identical across bands for ID consistency. Conflicts: python/lsst/pipe/tasks/multiBand.py
This class lives in coadd_utils (as opposed to pipe_tasks, where it currently lives in HSC).
laurenam
force-pushed
the
u/lauren/DM-1945
branch
from
04c54cc
to
bfb53fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.