ingestCalibs: add sky calib #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
approved these changes
Mar 2, 2017
PaulPrice
force-pushed
the
tickets/DM-9147
branch
from
91b3908
to
877bddd
Compare
PaulPrice
force-pushed
the
tickets/DM-9147
branch
2 times, most recently
from
631429c
to
a0df3de
Compare
pschella
reviewed
Nov 3, 2017
| Calibrated exposure. | ||
| """ | ||
| bg = dataRef.get("skyCorr") | ||
| if hasattr(calexp, "getMaskedImage"): |
There was a problem hiding this comment.
How about isinstance(calexp, Exposure) followed by an assert isinstance(calexp, MaskedImage)?
PaulPrice
force-pushed
the
tickets/DM-9147
branch
from
a0df3de
to
40f2edc
Compare
Sky corrections can be generating with the 'skyCorrection.py' executable in pipe_drivers. Because the sky model used by that code extends over the entire focal plane, this can produce better sky subtraction.
PaulPrice
force-pushed
the
tickets/DM-9147
branch
from
40f2edc
to
37cb96c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.