Update source to new Footprint API #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
requested changes
Apr 14, 2017
| @@ -868,7 +868,7 @@ def countMaskFromFootprint(mask, footprint, bitmask, ignoreMask): | |||
| bbox.clip(mask.getBBox(afwImage.PARENT)) | |||
| fp = afwImage.MaskU(bbox) | |||
| subMask = mask.Factory(mask, bbox, afwImage.PARENT) | |||
| afwDet.setMaskFromFootprint(fp, footprint, bitmask) | |||
| footprint.spans.setMask(fp, bitmask) | |||
There was a problem hiding this comment.
Huge 👍 on the improved (and more pythonic) API here! I especially like that you can just call footprint.spans as opposed to footprint.getSpans().
python/lsst/pipe/tasks/multiBand.py
Outdated
| foot.setPeakSchema(self.merged.getPeakSchema()) | ||
|
|
||
| if not foot.overlapsMask(mask): | ||
| if not foot.spans.overlaps(afwGeom.SpanSet.fromMask(mask)): |
There was a problem hiding this comment.
I don't know that I like this change. I think that SpanSet.overlaps should be overloaded to accept a mask, much like SpanSet.intersect, to prevent the user from having to unnecessarily cast a Mask to a SpanSet.
There was a problem hiding this comment.
With that said, in this particular instance it would probably be better to create an object maskSpanSet=afwGeom.SpanSet.fromMask(mask) before line 827, to avoid recasting it to the exact same object in each iteration of the loop.
natelust
force-pushed
the
tickets/DM-8108
branch
2 times, most recently
from
05489e3
to
340ba80
Compare
natelust
force-pushed
the
tickets/DM-8108
branch
from
340ba80
to
b41b948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.