DM-7477: Increase mask plane size to 32 bits #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
changed the title
PaulPrice
approved these changes
Jul 11, 2017
| \ref WcsSelectImagesTask_ "WcsSelectImagesTask" to select exposures that lie inside the patch | ||
| Get the corners of the bbox supplied in skyInfo using \ref afwGeom.Box2D and convert the pixel | ||
| positions of the bbox corners to sky coordinates using \ref skyInfo.wcs.pixelToSky. Use the | ||
| \ref WcsSelectImagesTask_ "WcsSelectImagesTask" to select exposures that lie inside the patch |
| @@ -144,7 +144,7 @@ def selectExposures(self, patchRef, skyInfo=None, selectDataList=[]): | |||
|
|
|||
| def getSkyInfo(self, patchRef): | |||
| """! | |||
| \brief Use \ref getSkyinfo to return the skyMap, tract and patch information, wcs and the outer bbox | |||
| \brief Use \ref getSkyinfo to return the skyMap, tract and patch information, wcs and the outer bbox | |||
| self.bitmask = lsst.afw.image.MaskU.getPlaneBitMask(self.config.maskPlaneName) | ||
| lsst.afw.image.Mask[lsst.afw.image.MaskPixel].addMaskPlane(self.config.maskPlaneName) | ||
| self.bitmask = lsst.afw.image.Mask[lsst.afw.image.MaskPixel]\ | ||
| .getPlaneBitMask(self.config.maskPlaneName) |
There was a problem hiding this comment.
I think if you put the period on the line before, you don't need the (evil) backslash.
But the line will shorten when we remove the [lsst.afw.image.MaskPixel].
| del trialInstance | ||
|
|
||
| def testFakeMaskUsed(self): | ||
| def testFakeMasksed(self): |
The transition to int32 for Masks triggered a name change for masks. Update to the new api.
natelust
force-pushed
the
tickets/DM-7477
branch
from
aa28086
to
755da7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.