DM-11951: Fixes in AL Decorrelation and Zogy #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
approved these changes
Sep 19, 2017
| @@ -323,7 +323,8 @@ def run(self, sensorRef, templateIdList=None): | |||
| spatiallyVarying = self.config.doSpatiallyVarying | |||
| subtractRes = self.subtract.subtractExposures(templateExposure, exposure, | |||
| doWarping=True, | |||
| spatiallyVarying=spatiallyVarying) | |||
| spatiallyVarying=spatiallyVarying, | |||
There was a problem hiding this comment.
For simplicity of code, readability and consistency with the new next line, I gently suggest you use spatiallyVarying=self.config.doSpatiallyVarying, here and ditch line 323. This same thing appears once more in the code and would benefit from the same treatment.
djreiss
force-pushed
the
tickets/DM-11951
branch
from
d5a7f96
to
42261f2
Compare
djreiss
force-pushed
the
tickets/DM-11951
branch
from
a51fc44
to
8a1802b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.