DM-12108: Add fake sources after wcs update #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message says that this change is important for getting coadds to be consistent. Isn't it also true that you need this change even if you are only running a single image? The coordinates must be incorrect for the fake sources if you are not using the correct wcs. |
rearmstr
commented
Oct 24, 2017
python/lsst/pipe/tasks/calibrate.py
Outdated
| sourceCat=sourceCat) | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
You can remove at least one of these blank lines.
rearmstr
commented
Oct 24, 2017
To make adding fake sources at specific locations happen consistently from visit to visit, they must be added after the wcs has been updated from that inserted by the telescope. This necessitates that detection and measurement be rerun with the fake sources inserted fixup
natelust
force-pushed
the
tickets/DM-12108
branch
from
8878411
to
fbc67ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If adding fake sources are to be consistent in every frame that
goes into a coadd, they must be added after the wcs has been
updated from that inserted by the telescope. This necessitates that
detection and measurement be rerun with the fake sources inserted